Skip to content

Conversation

@thanoskyprianos
Copy link
Contributor

  • There was a segfault happening when dumping branch predictor stats and the branch predictor was disabled
  • The initial state check of the smith 2 branch predictor was wrong
  • I improved the descriptions of the d-cache and l2-cache options that did not mention the writeback feature was configurable, even though the implementation is there.

@thanoskyprianos thanoskyprianos changed the title CLI Branch Predictor bugfixes and options help enhancements CLI Branch Predictor bugfixes and options' description enhancements Jan 3, 2026
@ppisa ppisa requested review from jdupak and ppisa January 3, 2026 22:28
Copy link
Member

@ppisa ppisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, generally looks good for me but I suggest to combine two mentioned patches together.

@ppisa ppisa added this pull request to the merge queue Jan 4, 2026
Merged via the queue into cvut:master with commit c2936ea Jan 4, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants