Skip to content

Conversation

@PTNobel
Copy link
Member

@PTNobel PTNobel commented Jan 8, 2026

Description

I was testing Claude out on some stuff, and I told it to implement the rest of the affine atoms.

This PR is mostly so we can split verifying the implementations.

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Benchmarks that have stayed the same:

   before           after         ratio
 [53826053]       [e7f01ecd]
     14.8±0ms         15.0±0ms     1.02  simple_LP_benchmarks.SimpleFullyParametrizedLPBenchmark.time_compile_problem
      13.8±0s          14.0±0s     1.01  finance.CVaRBenchmark.time_compile_problem
      1.11±0s          1.13±0s     1.01  gini_portfolio.Cajas.time_compile_problem
      170±0ms          172±0ms     1.01  high_dim_convex_plasticity.ConvexPlasticity.time_compile_problem
      891±0ms          898±0ms     1.01  simple_QP_benchmarks.LeastSquares.time_compile_problem
      23.5±0s          23.5±0s     1.00  sdp_segfault_1132_benchmark.SDPSegfault1132Benchmark.time_compile_problem
     39.5±0ms         39.6±0ms     1.00  matrix_stuffing.SmallMatrixStuffing.time_compile_problem
      281±0ms          282±0ms     1.00  matrix_stuffing.ParamSmallMatrixStuffing.time_compile_problem
      686±0ms          687±0ms     1.00  matrix_stuffing.ConeMatrixStuffingBench.time_compile_problem
      1.38±0s          1.37±0s     1.00  matrix_stuffing.ParamConeMatrixStuffing.time_compile_problem
      4.75±0s          4.75±0s     1.00  huber_regression.HuberRegression.time_compile_problem
      5.07±0s          5.04±0s     1.00  optimal_advertising.OptimalAdvertising.time_compile_problem
      549±0ms          546±0ms     0.99  semidefinite_programming.SemidefiniteProgramming.time_compile_problem
      348±0ms          346±0ms     0.99  gini_portfolio.Yitzhaki.time_compile_problem
      264±0ms          262±0ms     0.99  simple_QP_benchmarks.SimpleQPBenchmark.time_compile_problem
      5.45±0s          5.40±0s     0.99  svm_l1_regularization.SVMWithL1Regularization.time_compile_problem
      1.13±0s          1.11±0s     0.99  finance.FactorCovarianceModel.time_compile_problem
      243±0ms          240±0ms     0.98  gini_portfolio.Murray.time_compile_problem
     15.1±0ms         14.8±0ms     0.98  simple_QP_benchmarks.ParametrizedQPBenchmark.time_compile_problem
      12.1±0s          11.8±0s     0.98  simple_LP_benchmarks.SimpleLPBenchmark.time_compile_problem
      985±0ms          961±0ms     0.98  simple_LP_benchmarks.SimpleScalarParametrizedLPBenchmark.time_compile_problem
      1.94±0s          1.89±0s     0.97  simple_QP_benchmarks.UnconstrainedQP.time_compile_problem
      317±0ms          304±0ms     0.96  slow_pruning_1668_benchmark.SlowPruningBenchmark.time_compile_problem
      3.23±0s          3.07±0s     0.95  quantum_hilbert_matrix.QuantumHilbertMatrix.time_compile_problem
      1.81±0s          1.70±0s     0.94  tv_inpainting.TvInpainting.time_compile_problem

@PTNobel
Copy link
Member Author

PTNobel commented Jan 8, 2026

I have no faith in the Integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants