Replace diff_engine_core submodule with subtree#145
Closed
PTNobel wants to merge 3 commits intocvxpy-mergefrom
Closed
Replace diff_engine_core submodule with subtree#145PTNobel wants to merge 3 commits intocvxpy-mergefrom
PTNobel wants to merge 3 commits intocvxpy-mergefrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
git-subtree-dir: diff_engine_core git-subtree-split: fa65481d9cfdc91a150ef323772e9936eb6c93ef
Squashed from https://github.com/dance858/DNLP-diff-engine at fa65481. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
I think Daniel and William will have to update the copyright headers in the DNLP engine before this gets merged into CVXPY master. |
|
Benchmarks that have stayed the same: |
Member
|
thanks for making this PR @PTNobel , as discussed offline we ended up creating a PyPI package called |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the
diff_engine_coregit submodule with a git subtree. This eliminates the need forgit submodule init/updatewhen cloning the repo — the code is included directly.The subtree is squashed from https://github.com/dance858/DNLP-diff-engine at commit
fa65481.Future updates can be pulled with:
Type of change
Contribution checklist
🤖 Generated with Claude Code