Merged
Conversation
|
Benchmarks that have improved:
Benchmarks that have stayed the same: |
Transurgeon
approved these changes
Mar 4, 2026
Member
Transurgeon
left a comment
Transurgeon
left a comment
There was a problem hiding this comment.
Looks good, really nice fixes!
PTNobel
approved these changes
Mar 4, 2026
Member
PTNobel
left a comment
PTNobel
left a comment
There was a problem hiding this comment.
Looks awesome. Thanks Daniel! A couple quick comments.
| def div_canon(expr, args): | ||
|
|
||
| # raise an error if the denominator is not nonnegative | ||
| if not args[1].is_nonneg(): |
Member
There was a problem hiding this comment.
Suggested change
| if not args[1].is_nonneg(): | |
| if not (args[1].get_bounds()[0] >= 0).all(): |
This will allow more code than your version; which is something we need to fix at some point 😅
| def entr_canon(expr, args): | ||
| t = Variable(args[0].shape, bounds=[0, None]) | ||
| t = Variable(args[0].shape, nonneg=True) | ||
| if args[0].value is not None: |
Member
There was a problem hiding this comment.
I thought the value had to be non-None at this point in the DNLP canon process
Member
There was a problem hiding this comment.
I had missed your reply on the other thread! Thanks for clarifying. Discregard the resolved ones.
|
|
||
| return expr.copy([t]), [t == args[0]] | ||
|
|
||
| sinh_canon = smooth_full_domain_canon |
Member
There was a problem hiding this comment.
My preference is to just have these mappings in the dictionary rather than here; but I trust your judgement on this.
Member
|
@PTNobel I'll merge this based on your comment on the cvxpy-merge PR. |
Member
|
Please address my two comments here too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.