Skip to content

adding more smooth canonicalizers#3

Merged
Transurgeon merged 2 commits intomasterfrom
working-on-smooth-canons
Jun 30, 2025
Merged

adding more smooth canonicalizers#3
Transurgeon merged 2 commits intomasterfrom
working-on-smooth-canons

Conversation

@Transurgeon
Copy link
Member

Description

Please include a short summary of the change.
Issue link (if applicable):

Type of change

  • New feature (backwards compatible)
  • New feature (breaking API changes)
  • Bug fix
  • Other (Documentation, CI, ...)

Contribution checklist

  • Add our license to new files.
  • Check that your code adheres to our coding style.
  • Write unittests.
  • Run the unittests and check that they’re passing.
  • Run the benchmarks to make sure your change doesn’t introduce a regression.

@Transurgeon Transurgeon merged commit 41bb677 into master Jun 30, 2025
21 of 24 checks passed
@github-actions
Copy link

Benchmarks that have stayed the same:

   before           after         ratio
 [4544ef77]       [5a83de3f]
      236±0ms          257±0ms     1.09  gini_portfolio.Murray.time_compile_problem
      13.7±0s          14.6±0s     1.07  finance.CVaRBenchmark.time_compile_problem
      1.12±0s          1.19±0s     1.06  finance.FactorCovarianceModel.time_compile_problem
     44.8±0ms         47.7±0ms     1.06  matrix_stuffing.SmallMatrixStuffing.time_compile_problem
      1.66±0s          1.76±0s     1.06  tv_inpainting.TvInpainting.time_compile_problem
      4.74±0s          4.90±0s     1.03  huber_regression.HuberRegression.time_compile_problem
      348±0ms          355±0ms     1.02  gini_portfolio.Yitzhaki.time_compile_problem
      1.11±0s          1.13±0s     1.02  gini_portfolio.Cajas.time_compile_problem
      5.04±0s          5.10±0s     1.01  optimal_advertising.OptimalAdvertising.time_compile_problem
      738±0ms          740±0ms     1.00  matrix_stuffing.ConeMatrixStuffingBench.time_compile_problem
      304±0ms          305±0ms     1.00  slow_pruning_1668_benchmark.SlowPruningBenchmark.time_compile_problem
      248±0ms          248±0ms     1.00  high_dim_convex_plasticity.ConvexPlasticity.time_compile_problem
      880±0ms          879±0ms     1.00  simple_QP_benchmarks.LeastSquares.time_compile_problem
      23.1±0s          23.0±0s     0.99  sdp_segfault_1132_benchmark.SDPSegfault1132Benchmark.time_compile_problem
      1.88±0s          1.87±0s     0.99  simple_QP_benchmarks.UnconstrainedQP.time_compile_problem
      259±0ms          257±0ms     0.99  simple_QP_benchmarks.SimpleQPBenchmark.time_compile_problem
      5.48±0s          5.44±0s     0.99  semidefinite_programming.SemidefiniteProgramming.time_compile_problem
      967±0ms          957±0ms     0.99  simple_LP_benchmarks.SimpleScalarParametrizedLPBenchmark.time_compile_problem
      11.7±0s          11.6±0s     0.99  simple_LP_benchmarks.SimpleLPBenchmark.time_compile_problem
      5.33±0s          5.27±0s     0.99  svm_l1_regularization.SVMWithL1Regularization.time_compile_problem
      2.38±0s          2.35±0s     0.99  simple_LP_benchmarks.SimpleFullyParametrizedLPBenchmark.time_compile_problem
      302±0ms          296±0ms     0.98  matrix_stuffing.ParamSmallMatrixStuffing.time_compile_problem
      3.56±0s          3.44±0s     0.97  quantum_hilbert_matrix.QuantumHilbertMatrix.time_compile_problem
      603±0ms          571±0ms     0.95  simple_QP_benchmarks.ParametrizedQPBenchmark.time_compile_problem
      1.51±0s          1.39±0s     0.92  matrix_stuffing.ParamConeMatrixStuffing.time_compile_problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant