Skip to content

Conversation

@Transurgeon
Copy link
Member

Description

Please include a short summary of the change.
Issue link (if applicable):

Type of change

  • New feature (backwards compatible)
  • New feature (breaking API changes)
  • Bug fix
  • Other (Documentation, CI, ...)

Contribution checklist

  • Add our license to new files.
  • Check that your code adheres to our coding style.
  • Write unittests.
  • Run the unittests and check that they’re passing.
  • Run the benchmarks to make sure your change doesn’t introduce a regression.

@Transurgeon Transurgeon marked this pull request as draft September 2, 2025 21:41
@Transurgeon
Copy link
Member Author

just writing down some thoughts from the tests:

the paper by smith says we should introduce new variables for both the numerator and denominator of a division operator.

image

Maybe we could try doing that as well.

Another point is the second sentence of the image above : "We also need to replace the entire
expression by a new variable defined in terms of a linear fractional term". I am wondering if this means we should just create a new variable and set its value to w_j.value/w_{j+1}.value. The alternative would be to create an equality constraint with w_{j+2} == w_j.value/w_{j+1}.value. Basically, I am wondering if we should differ between equality constraints and a new variable "defined in terms of a linear fractional term". However, one thing is sure, we should output a new variable for the output of the div operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants