Skip creating args for case when only one TestParams#74
Open
mekegi wants to merge 4 commits intocweill:masterfrom
Open
Skip creating args for case when only one TestParams#74mekegi wants to merge 4 commits intocweill:masterfrom
mekegi wants to merge 4 commits intocweill:masterfrom
Conversation
```
tests := []struct {
name string
arg string
}{
// TODO: Add test cases.
}
for _, tt := range tests {
Foo3(tt.arg)
}
```
instead of
```
type args struct {
s string
}
tests := []struct {
name string
args args
}{
// TODO: Add test cases.
}
for _, tt := range tests {
Foo3(tt.args.s)
}
```
merge master from cweill/gotests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of cases when func with one param
func Sin(x int) int,or writers
func Write(w io.Writer, b []bytes)and in generated tests for such func we see a lot of boilercode like
type args struct { x int }In my pull request I try ti prevent creating unuseful args type for one param
Now generated tests looks like:
instead of