gotests generate test names with MixedCaps#80
Open
jeffbean wants to merge 2 commits intocweill:masterfrom
Open
gotests generate test names with MixedCaps#80jeffbean wants to merge 2 commits intocweill:masterfrom
jeffbean wants to merge 2 commits intocweill:masterfrom
Conversation
…or test files but maybe should be?
jeffbean
force-pushed
the
test-mixedcaps
branch
from
c2c305d to
974312f
Compare
Owner
|
You should contribute to the discussion at golang/go#33688. We should get consensus from the Go community about how to best generate tests like these. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the gotests
TestNamefunction to follow the effective Go guide of MixedCaps.This tool generates code that does not follow the Go effective style guide.
In this change we only change the
TestNamefrom adding_to returning the Title version of the string that was intended for the test name. This give a MixedCaps test name.Another angle would be to add a func to the Templates
FuncMapto allow custom templates to replace the_s and Title the string in the template. This seems like a change that would best be default since it is following the effective Go guide.