Implement Football Offers Report #657
Open
+148
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwendt94
reviewed
Aug 27, 2025
Owner
cwendt94
left a comment
cwendt94
left a comment
There was a problem hiding this comment.
Overall looks good! Just some small comments.
| '''Returns a list of free agent auction bids''' | ||
| if week is None: | ||
| bids = [] | ||
| for week in range(0, 18): |
Owner
There was a problem hiding this comment.
For base league this could be used for other sports, I would suggest using the field self.finalScoringPeriod for rnage
| else: | ||
| data = self.espn_request.get_league_offers(week=week) | ||
| bids = data.get('transactions', []) | ||
| print(bids) |
| @@ -0,0 +1,64 @@ | |||
| from datetime import datetime | |||
Owner
There was a problem hiding this comment.
I think this can be moved outside of football as base_offer.py so other sports can use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to get a list of offers, including unsuccessful bids, for either the whole season, or a specific week.