Fixed binaries names for lrelease and lupdate on recent MSYS64#6929
Merged
Fixed binaries names for lrelease and lupdate on recent MSYS64#6929
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes build breakage on recent MSYS64 systems following the Qt6 package update on January 6, 2026, where the Qt translation tools were renamed from lupdate-qt6.exe/lrelease-qt6.exe to lupdate.exe/lrelease.exe. The fix uses the CI environment variable to distinguish between GitHub Actions (which still has the old -qt6 suffixed binaries) and up-to-date local development environments (which have the new unsuffixed binaries).
Changes:
- Updated binary name references in build configuration to handle both old (CI) and new (local) MSYS64 versions
- Updated copyright year to 2025
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/install/msys64_installer.sh | Updated comment to reflect new binary names (lupdate and lrelease without -qt6 suffix) |
| resources/translations/Makefile | Added conditional logic using CI environment variable to use -qt6 suffixed binaries in GitHub Actions and unsuffixed binaries in local dev environments; updated copyright year to 2025 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CoolSpy3
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On January 6th 2026, Qt6 became the default in MSYS64, see https://github.com/msys2/MINGW-packages/commits/master/mingw-w64-qt6-tools
As a consequence the
lupdate-qt6.exeandlrelease-qt6.exewere renamed tolupdate.exeandlrelease.exe, thus breaking the build on recent MSYS64 system.However, in the GitHub CI, we still have the old version where these binary have the
-qt6suffix. So, we need to distinguish the CI case from the normal up-to-date development environment.Hopefully this difference will disappear soon, when MSYS64 is updated in the GitHub CI.