Skip to content

Fixed binaries names for lrelease and lupdate on recent MSYS64#6929

Merged
omichel merged 4 commits intomasterfrom
fix-lupdate-lrelease-on-recent-msys64
Feb 8, 2026
Merged

Fixed binaries names for lrelease and lupdate on recent MSYS64#6929
omichel merged 4 commits intomasterfrom
fix-lupdate-lrelease-on-recent-msys64

Conversation

@omichel
Copy link
Copy Markdown
Member

@omichel omichel commented Feb 6, 2026

On January 6th 2026, Qt6 became the default in MSYS64, see https://github.com/msys2/MINGW-packages/commits/master/mingw-w64-qt6-tools
As a consequence the lupdate-qt6.exe and lrelease-qt6.exe were renamed to lupdate.exe and lrelease.exe, thus breaking the build on recent MSYS64 system.

However, in the GitHub CI, we still have the old version where these binary have the -qt6 suffix. So, we need to distinguish the CI case from the normal up-to-date development environment.
Hopefully this difference will disappear soon, when MSYS64 is updated in the GitHub CI.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes build breakage on recent MSYS64 systems following the Qt6 package update on January 6, 2026, where the Qt translation tools were renamed from lupdate-qt6.exe/lrelease-qt6.exe to lupdate.exe/lrelease.exe. The fix uses the CI environment variable to distinguish between GitHub Actions (which still has the old -qt6 suffixed binaries) and up-to-date local development environments (which have the new unsuffixed binaries).

Changes:

  • Updated binary name references in build configuration to handle both old (CI) and new (local) MSYS64 versions
  • Updated copyright year to 2025

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
scripts/install/msys64_installer.sh Updated comment to reflect new binary names (lupdate and lrelease without -qt6 suffix)
resources/translations/Makefile Added conditional logic using CI environment variable to use -qt6 suffixed binaries in GitHub Actions and unsuffixed binaries in local dev environments; updated copyright year to 2025

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@CoolSpy3 CoolSpy3 added the test webots build Start the build tests label Feb 7, 2026
Copy link
Copy Markdown
Contributor

@CoolSpy3 CoolSpy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the joys of GitHub Actions versioning 🙃 I flagged this for a build to verify that this does, in fact, pass CI, but if that succeeds, this is good.

@omichel omichel merged commit 23d9d8b into master Feb 8, 2026
20 checks passed
@omichel omichel deleted the fix-lupdate-lrelease-on-recent-msys64 branch February 8, 2026 16:13
omichel added a commit that referenced this pull request Mar 23, 2026
omichel added a commit that referenced this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test webots build Start the build tests

Development

Successfully merging this pull request may close these issues.

3 participants