Skip to content

Fix DLL directory handle retention in Python controller on Windows #6934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omichel merged 2 commits into from
Feb 12, 2026
+5 −2
Merged

Fix DLL directory handle retention in Python controller on Windows #6934

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f04334
Initial plan
Copilot Feb 12, 2026
abf5cb9
Store DLL directory handles to prevent garbage collection
Copilot Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/controller/python/controller/wb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
import os
import sys

# Keep DLL directory handles alive to prevent garbage collection (Windows only)
_dll_directory_handles = []

if sys.platform == 'linux' or sys.platform == 'linux2':
path = os.path.join('lib', 'controller', 'libController.so')
elif sys.platform == 'win32':
Expand All @@ -31,14 +34,14 @@
os.path.join(webots_home, 'msys64', 'mingw64', 'bin'),
]:
if os.path.isdir(dll_dir):
os.add_dll_directory(dll_dir)
_dll_directory_handles.append(os.add_dll_directory(dll_dir))
# For development builds running from source, also check the system MSYS2 installation.
mingw_bin = os.path.join(os.environ.get('MSYS2_HOME',
os.path.splitdrive(sys.executable)[0] + os.sep + 'msys64'),
'mingw64',
'bin')
if os.path.isdir(mingw_bin):
os.add_dll_directory(mingw_bin)
_dll_directory_handles.append(os.add_dll_directory(mingw_bin))
elif sys.platform == 'darwin':
path = os.path.join('Contents', 'lib', 'controller', 'libController.dylib')

Expand Down
Loading