Skip to content

Safe floating point sum on aggregates rebuild #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Safe floating point sum on aggregates rebuild #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
063f1b0
Safe floating point sum on aggregatesπ rebuild
antonkomarev Apr 9, 2023
13ec9cd
Safe floating point sum on aggregates rebuild
antonkomarev Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Reactant/Jobs/RebuildReactionAggregatesJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,15 @@ private function recountReactionTotal(): void
}

$totalCount = ReactionTotal::COUNT_DEFAULT;
$totalWeight = ReactionTotal::WEIGHT_DEFAULT;
$totalWeight = 0;

foreach ($counters as $counter) {
$totalCount += $counter->getCount();
$totalWeight += $counter->getWeight();
$totalWeight += intval($counter->getWeight() * 100);
}

$totalWeight = $totalWeight / 100;

$reactionTotal = $this->findOrCreateReactionTotal();

/** @var \Cog\Laravel\Love\Reactant\ReactionTotal\Models\ReactionTotal $reactionTotal */
Expand Down
37 changes: 37 additions & 0 deletions tests/Unit/Console/Commands/RecountTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,6 +906,43 @@ public function it_resets_reaction_total_weight_on_recount(): void
$this->assertSame(0.0, $reactant2->reactionTotal->weight);
}

/** @test */
public function it_sums_reaction_total_weight_with_floating_point_issue(): void
{
$reactionType = ReactionType::factory()->create(['mass' => 1]);
$reactant1 = Reactant::factory()->create();
$reactant2 = Reactant::factory()->create();
Reaction::factory()->create([
'reaction_type_id' => $reactionType->getKey(),
'reactant_id' => $reactant1,
'rate' => 0.2,
]);
Reaction::factory()->create([
'reaction_type_id' => $reactionType->getKey(),
'reactant_id' => $reactant1,
'rate' => 0.1,
]);
Reaction::factory()->create([
'reaction_type_id' => $reactionType->getKey(),
'reactant_id' => $reactant2,
'rate' => 0.01,
]);
Reaction::factory()->create([
'reaction_type_id' => $reactionType->getKey(),
'reactant_id' => $reactant2,
'rate' => 0.01,
]);

$this->artisan('love:recount');

/**
* @see https://www.php.net/manual/en/language.types.float.php#language.types.float.comparison
*/
$epsilon = 0.0000000000000001;
$this->assertTrue(abs($reactant1->reactionTotal->weight - 0.3) < $epsilon);
$this->assertTrue(abs($reactant2->reactionTotal->weight - 0.02) < $epsilon);
}

private function reactionsCount(
ReactantInterface $reactant,
ReactionTypeInterface $reactionType
Expand Down