-
Notifications
You must be signed in to change notification settings - Fork 68
WebUI: improve metrics preset ordering and descriptions #1078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I guess the PR is not ready for review yet, right?, please make it a draft until its ready. |
|
Thanks for pointing that out! Yes, the PR is still a work in progress. I’ll convert it to a draft and fix the failing checks before requesting review again. |
Pull Request Test Coverage Report for Build 20312847398Details
💛 - Coveralls |
|
Thanks for your effort, please make the sorting order as follows: And make this ordering the default ordering in the Presets tab as well. |
|
A tip: always use a dedicated branch for your changes, don't push to master directly. |
|
Thanks for the clarification and the ordering list 👍 Also noted about using a dedicated branch — I’ll follow that going forward. |
|
Thanks for the review! 🙏 |
|
overtaken by #1086 |
This PR improves the UX of metric preset selection when adding a source.
Changes:
Fixes #1051