Skip to content

Conversation

@Mahi1801
Copy link

This PR improves the UX of metric preset selection when adding a source.

Changes:

  • Improves logical ordering of metric presets
  • Makes preset selection clearer and more intuitive
  • Aligns ordering across UI components

Fixes #1051

@0xgouda
Copy link
Collaborator

0xgouda commented Dec 16, 2025

I guess the PR is not ready for review yet, right?, please make it a draft until its ready.

@Mahi1801
Copy link
Author

Thanks for pointing that out! Yes, the PR is still a work in progress. I’ll convert it to a draft and fix the failing checks before requesting review again.

@Mahi1801 Mahi1801 marked this pull request as draft December 16, 2025 05:50
@coveralls
Copy link

Pull Request Test Coverage Report for Build 20312847398

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.807%

Totals Coverage Status
Change from base Build 20232445327: 0.0%
Covered Lines: 3804
Relevant Lines: 5154

💛 - Coveralls

@0xgouda 0xgouda marked this pull request as ready for review December 18, 2025 07:29
@0xgouda 0xgouda self-assigned this Dec 18, 2025
@0xgouda
Copy link
Collaborator

0xgouda commented Dec 18, 2025

Thanks for your effort, please make the sorting order as follows:

minimal
basic
standard
exhaustive
full
aiven
azure
gce
rds
pgbouncer
pgpool
unprivileged
recommendations
prometheus-async
exhaustive_no_python
debug

And make this ordering the default ordering in the Presets tab as well.

@0xgouda
Copy link
Collaborator

0xgouda commented Dec 18, 2025

A tip: always use a dedicated branch for your changes, don't push to master directly.

@Mahi1801
Copy link
Author

Thanks for the clarification and the ordering list 👍
I’ll update the preset sorting to match this order and apply the same ordering in the Presets tab as well.

Also noted about using a dedicated branch — I’ll follow that going forward.

@Mahi1801
Copy link
Author

Thanks for the review! 🙏
I’ve moved the changes to a dedicated branch and updated the preset sorting order as requested.
Please let me know if any further adjustments are needed.

@0xgouda
Copy link
Collaborator

0xgouda commented Dec 19, 2025

overtaken by #1086

@0xgouda 0xgouda closed this Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metrics menu

3 participants