[!] add schema migration support for PostgreSQL sinks, closes #1110 #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `admin.migration` table and migration infrastructure to sink - Implement `Migrate()` and `NeedsMigration()` for `PostgresWriter` and `MultiWriter` - Add migration checks during sink initialization with error messages - Extend `config init/upgrade` commands to support sink migrations - `NewWriterFromPostgresConn` now returns nil writer on errors - Add comprehensive test coverage for migration happy/unhappy paths - Update docs to document sink database migration support Migration pattern follows existing metrics database approach, ensuring both config and sink databases can be upgraded independently using the same `pgwatch config upgrade` command.
Pull Request Test Coverage Report for Build 20717611432Details
💛 - Coveralls |
pashagolub
added
enhancement
pashagolub
force-pushed
the
1110-apply-postgres-sink-schema-migrations
branch
from
8d3c63f to
b8e65f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
admin.migrationtable and migration infrastructure to sinkMigrate()andNeedsMigration()forPostgresWriterandMultiWriterconfig init/upgradecommands to support sink migrationsNewWriterFromPostgresConnnow returns nil writer on errorsMigration pattern follows existing metrics database approach, ensuring both config and sink databases can be upgraded independently using the same
pgwatch config upgradecommand.