Skip to content

Conversation

@pashagolub
Copy link
Collaborator

This change aims to ease v4 -> v5 migration be having subpartitions schema untouched. User will empty/drop admin schema and re-init it with pgwatch. Existing subpartitions and public tables should be used as is.

@pashagolub pashagolub self-assigned this Jan 7, 2026
@pashagolub pashagolub requested a review from 0xgouda January 7, 2026 12:51
@pashagolub pashagolub added refactoring Something done as it should've been done from the start sinks Where and how to store monitored data labels Jan 7, 2026
@coveralls
Copy link

coveralls commented Jan 7, 2026

Pull Request Test Coverage Report for Build 20783883445

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.296%

Totals Coverage Status
Change from base Build 20783434612: 0.0%
Covered Lines: 4011
Relevant Lines: 5327

💛 - Coveralls

Copy link
Collaborator

@0xgouda 0xgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This change aims to ease v4 -> v5 migration be having `subpartitions`
schema untouched. User will empty/drop `admin` schema and re-init it
with pgwatch. Existing `subpartitions` and `public` tables should be
used as is.
@0xgouda 0xgouda force-pushed the handle-sink-schemas branch from 7689ace to 3688f4e Compare January 7, 2026 13:57
@0xgouda 0xgouda merged commit b3eb15b into master Jan 7, 2026
9 checks passed
@0xgouda 0xgouda deleted the handle-sink-schemas branch January 7, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Something done as it should've been done from the start sinks Where and how to store monitored data

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants