[-] fix data race in Prometheus sink, fixes #1136#1140
Merged
pashagolub merged 5 commits intocybertec-postgresql:masterfrom Feb 3, 2026
Merged
[-] fix data race in Prometheus sink, fixes #1136#1140pashagolub merged 5 commits intocybertec-postgresql:masterfrom
pashagolub merged 5 commits intocybertec-postgresql:masterfrom
Conversation
pashagolub
reviewed
Jan 25, 2026
Pull Request Test Coverage Report for Build 21636114330Details
💛 - Coveralls |
Contributor
Author
|
@pashagolub ping for review |
Collaborator
|
Could you please add a test case that must fail before the change and is working now. Thanks |
Contributor
Author
Done! Please let me know if there any additional changes necessary |
pashagolub
added
bug
pashagolub
force-pushed
the
fix-collect-data-race
branch
from
3505760 to
2c3e3e2
Compare
pashagolub
force-pushed
the
fix-collect-data-race
branch
from
440017c to
dcb0b4a
Compare
pashagolub
approved these changes
Feb 3, 2026
pashagolub
changed the title
Collaborator
|
Thanks! |
Contributor
Author
I see, can I then open an issue to refactor it and make it part of a struct? |
Collaborator
|
absolutely. be my guest! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1136.
Will add the test as part of the PR to add tests to prometheus.go