Skip to content

[#1092] Enhance metric form UI#1184

Open
Mazen050 wants to merge 2 commits intocybertec-postgresql:masterfrom
Mazen050:enhance-metric-form
Open

[#1092] Enhance metric form UI#1184
Mazen050 wants to merge 2 commits intocybertec-postgresql:masterfrom
Mazen050:enhance-metric-form

Conversation

@Mazen050
Copy link
Contributor

@Mazen050 Mazen050 commented Feb 6, 2026

Closes #1092

This PR Enhances the look of the metric form UI by introducing 2 individual boxs one for postgres version number and the other for sql, with another button to add New SQL.

Examples of how it looks:

Screenshot 2026-02-06 235227 image

Also versions dropdown is editable and can be used to add a new versions, and it also successfully retrieves older metric sql from backend.

@coveralls
Copy link

coveralls commented Feb 9, 2026

Pull Request Test Coverage Report for Build 21963883272

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.834%

Totals Coverage Status
Change from base Build 21924096081: 0.0%
Covered Lines: 4179
Relevant Lines: 5439

💛 - Coveralls

@0xgouda 0xgouda self-assigned this Feb 9, 2026
@0xgouda 0xgouda added the webui Admin UI related issues label Feb 9, 2026
@0xgouda
Copy link
Collaborator

0xgouda commented Feb 9, 2026

Thanks, will take a look tomorrow.

@Mazen050
Copy link
Contributor Author

Mazen050 commented Feb 9, 2026

Please note that I have added a TODO in the form to restrict input to numbers and dots maybe in the future or maybe in this PR depends if it's needed or not.

@Mazen050 Mazen050 force-pushed the enhance-metric-form branch from 791897e to 1324703 Compare February 10, 2026 19:09
@Mazen050
Copy link
Contributor Author

I have made the version input allow only numbers and dots.

@Mazen050 Mazen050 force-pushed the enhance-metric-form branch from 1324703 to db4d02a Compare February 12, 2026 20:53
@pashagolub
Copy link
Collaborator

thanks for working on this! I have doubts if such UI is reasonably good for the current metrics that are usually several screens long. From the UX point of view it's impossible to make any sane actions with such a layout and lack of syntax highlightning

@Mazen050
Copy link
Contributor Author

Would making the text area bigger be any better? Currently it starts with 3 rows and expands to 12 rows and then it changes to scrolling.

So we can change the number of max rows or we can make the sql text area wider too since the version input doesn't need that much space.

About syntax highlighting we could use something like a codemirror component instead of the text area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

webui Admin UI related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement for new metric form in UI

4 participants