[#1092] Enhance metric form UI#1184
[#1092] Enhance metric form UI#1184Mazen050 wants to merge 2 commits intocybertec-postgresql:masterfrom
Conversation
Pull Request Test Coverage Report for Build 21963883272Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Thanks, will take a look tomorrow. |
|
Please note that I have added a |
791897e to
1324703
Compare
|
I have made the version input allow only numbers and dots. |
1324703 to
db4d02a
Compare
|
thanks for working on this! I have doubts if such UI is reasonably good for the current metrics that are usually several screens long. From the UX point of view it's impossible to make any sane actions with such a layout and lack of syntax highlightning |
|
Would making the text area bigger be any better? Currently it starts with 3 rows and expands to 12 rows and then it changes to scrolling. So we can change the number of max rows or we can make the sql text area wider too since the version input doesn't need that much space. About syntax highlighting we could use something like a codemirror component instead of the text area. |
Closes #1092
This PR Enhances the look of the metric form UI by introducing 2 individual boxs one for postgres version number and the other for sql, with another button to add New SQL.
Examples of how it looks:
Also versions dropdown is editable and can be used to add a new versions, and it also successfully retrieves older metric sql from backend.