[-] improve Prometheus scrapping, fixes #749#790
Merged
pashagolub merged 1 commit intomasterfrom Jun 9, 2025
Merged
Conversation
First make sure all sinks do not modify measurement envelopes, since maps in it reference to the same map in memory. Add improved Prometheus handler in sink, so logs will be populated with all scrapping errors. Clean cached measurements after each scrape, there is no need in serving the same data as it will be ignored anyway. Make sure all non-numeric fields are treated as labels. This will pollute some metrics, e.g. settings. It's better to rewrite metric queries if the number of labels is too high.
pashagolub
added
bug
Pull Request Test Coverage Report for Build 15540919971Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First make sure all sinks do not modify measurement envelopes, since maps in it reference to the same map in memory. Add improved Prometheus handler in sink, so logs will be populated with all scrapping errors. Clean cached measurements after each scrape, there is no need in serving the same data as it will be ignored anyway. Make sure all non-numeric fields are treated as labels. This will pollute some metrics, e.g. settings. It's better to rewrite metric queries if the number of labels is too high.