Skip to content

[-] fix instance_up metric, closes #759#791

Merged
pashagolub merged 1 commit intomasterfrom
759-fix-instance-up-metric
Jun 10, 2025
Merged

[-] fix instance_up metric, closes #759#791
pashagolub merged 1 commit intomasterfrom
759-fix-instance-up-metric

Conversation

@pashagolub
Copy link
Collaborator

Remove extra setInstanceUpDownState() from Prometheus sink. Add reaper.GetInstanceUpMeasurement() function and use it in FetchMetric()

Remove extra `setInstanceUpDownState()` from Prometheus sink. Add
`reaper.GetInstanceUpMeasurement()` function and use it in
`FetchMetric()`
@pashagolub pashagolub self-assigned this Jun 10, 2025
@pashagolub pashagolub added bug Something isn't working sinks Where and how to store monitored data labels Jun 10, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15557339569

Details

  • 0 of 32 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 60.5%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/reaper/database.go 0 10 0.0%
internal/reaper/reaper.go 0 22 0.0%
Files with Coverage Reduction New Missed Lines %
internal/reaper/reaper.go 2 0.0%
Totals Coverage Status
Change from base Build 15541270178: 0.3%
Covered Lines: 2688
Relevant Lines: 4443

💛 - Coveralls

@pashagolub pashagolub merged commit 0d9ed2a into master Jun 10, 2025
9 checks passed
@pashagolub pashagolub deleted the 759-fix-instance-up-metric branch June 10, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working sinks Where and how to store monitored data

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants