Skip to content

[+] optimize the size of metrics.MeasurementEnvelope#793

Merged
pashagolub merged 1 commit intomasterfrom
optimize-MeasurementEnvelope
Jun 10, 2025
Merged

[+] optimize the size of metrics.MeasurementEnvelope#793
pashagolub merged 1 commit intomasterfrom
optimize-MeasurementEnvelope

Conversation

@pashagolub
Copy link
Collaborator

Current sinks implementations do not need to know the source type info. Both real database name and system identifier are already included in the data if appropriate options are specified.

Current sinks implementations do not need to know the source type info.
Both real database name and system identifier are already included in
the data if appropriate options are specified.
@pashagolub pashagolub self-assigned this Jun 10, 2025
@pashagolub pashagolub added the refactoring Something done as it should've been done from the start label Jun 10, 2025
@pashagolub pashagolub merged commit a86fce9 into master Jun 10, 2025
9 checks passed
@pashagolub pashagolub deleted the optimize-MeasurementEnvelope branch June 10, 2025 13:44
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15560947891

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 8 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 60.519%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/reaper/reaper.go 0 4 0.0%
Totals Coverage Status
Change from base Build 15560326414: 0.02%
Covered Lines: 2684
Relevant Lines: 4435

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Something done as it should've been done from the start

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants