[+] improve recommendation metrics, #764#921
Merged
pashagolub merged 5 commits intomasterfrom Sep 1, 2025
Merged
Conversation
pashagolub
added
dashboards
Pull Request Test Coverage Report for Build 17376181939Details
💛 - Coveralls |
0xgouda
reviewed
Aug 31, 2025
0xgouda
reviewed
Aug 31, 2025
0xgouda
reviewed
Aug 31, 2025
0xgouda
reviewed
Sep 1, 2025
Refactor PostgreSQL recommendation metrics to consolidate multiple findings per metric type. The changes consolidate all 8 recommendation metrics to use an aggregation pattern that combines multiple database objects into comma-separated strings instead of separate rows, limiting results to 50 items with overflow indicators, and actionable guidance templates were added to extra_info fields.
pashagolub
force-pushed
the
764_improve_reco_metrics
branch
from
b141233 to
10cf4c4
Compare
Latest versions of pg_qualstats return not only CREATE INDEX but affected queries array. So use CREATE INDEX as is in recommendations, and output `queryids` if available in `extra_info`. Due to long recommendation text limit concatenated output to 10 items. Reported by @0xgouda.
pashagolub
added a commit
that referenced
this pull request
Sep 1, 2025
* [+] improve recommendation metrics, closes #764 Refactor PostgreSQL recommendation metrics to consolidate multiple findings per metric type. The changes consolidate all 8 recommendation metrics to use an aggregation pattern that combines multiple database objects into comma-separated strings instead of separate rows, limiting results to 50 items with overflow indicators, and actionable guidance templates were added to extra_info fields. * [-] fix `metric_storage_name` properties in YAML, fixes #920 * [+] improve "Recommendations" dashboard * [-] fix object name aggregation by @0xgouda * [-] tweak recommendations for `reco_add_index` metric Latest versions of pg_qualstats return not only CREATE INDEX but affected queries array. So use CREATE INDEX as is in recommendations, and output `queryids` if available in `extra_info`. Due to long recommendation text limit concatenated output to 10 items. Reported by @0xgouda. ------ Co-authored-by: Ahmed Gouda <gouda0x@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor PostgreSQL recommendation metrics to consolidate multiple
findings per metric type.
The changes consolidate all 8 recommendation metrics to use
an aggregation pattern that combines multiple database objects into
comma-separated strings instead of separate rows, limiting results to
50 items with overflow indicators, and actionable guidance templates
were added to extra_info fields.