Skip to content

[*] refactor object changes metric#984

Merged
pashagolub merged 1 commit intomasterfrom
refactor-object-changes-tracking
Oct 6, 2025
Merged

[*] refactor object changes metric#984
pashagolub merged 1 commit intomasterfrom
refactor-object-changes-tracking

Conversation

@pashagolub
Copy link
Collaborator

Rewrite the function so it follows the common calling conventions. Make sure Reaper.FetchMetric() exits if none measurements collected

Rewrite the function so it follows the common calling conventions. Make
sure `Reaper.FetchMetric()` exits if none measurements collected
@pashagolub pashagolub self-assigned this Oct 6, 2025
@pashagolub pashagolub added metrics Metrics related issues refactoring Something done as it should've been done from the start labels Oct 6, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18282923545

Details

  • 5 of 21 (23.81%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 70.862%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/reaper/metric.go 0 1 0.0%
internal/reaper/reaper.go 0 2 0.0%
internal/reaper/database.go 5 18 27.78%
Files with Coverage Reduction New Missed Lines %
internal/reaper/database.go 1 76.38%
Totals Coverage Status
Change from base Build 18228262317: 0.4%
Covered Lines: 3536
Relevant Lines: 4990

💛 - Coveralls

@pashagolub pashagolub merged commit 826bac1 into master Oct 6, 2025
13 of 14 checks passed
@pashagolub pashagolub deleted the refactor-object-changes-tracking branch October 6, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metrics Metrics related issues refactoring Something done as it should've been done from the start

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants