Skip to content

[+] improve partition deletion in postgres sink, close #786#985

Merged
pashagolub merged 1 commit intomasterfrom
786-detach-deleted-partitions
Oct 7, 2025
Merged

[+] improve partition deletion in postgres sink, close #786#985
pashagolub merged 1 commit intomasterfrom
786-detach-deleted-partitions

Conversation

@pashagolub
Copy link
Collaborator

This commit partially addresses #786 using DETACH PARTITION before the actual dropping to avoid locking.

@pashagolub pashagolub self-assigned this Oct 6, 2025
@pashagolub pashagolub added enhancement New feature or request sinks Where and how to store monitored data labels Oct 6, 2025
@coveralls
Copy link

coveralls commented Oct 6, 2025

Pull Request Test Coverage Report for Build 18307457096

Details

  • 15 of 16 (93.75%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 71.44%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/sinks/postgres.go 15 16 93.75%
Totals Coverage Status
Change from base Build 18307429676: 0.6%
Covered Lines: 3542
Relevant Lines: 4958

💛 - Coveralls

This commit partially addresses #786 using DETACH PARTITION before the
actual dropping to avoid locking.
@pashagolub pashagolub force-pushed the 786-detach-deleted-partitions branch from 6436ca4 to 8c54ad3 Compare October 7, 2025 08:57
@pashagolub pashagolub changed the title [+] improve partition deletion in postgres sink [+] improve partition deletion in postgres sink, close #786 Oct 7, 2025
@pashagolub pashagolub merged commit 560c3e8 into master Oct 7, 2025
9 checks passed
@pashagolub pashagolub deleted the 786-detach-deleted-partitions branch October 7, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request sinks Where and how to store monitored data

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants