Use /leader as default trigger key for Patroni DCS type #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hrm, not sure about the Github-Action failure, is that a known issue or something in the new project? |
Collaborator
|
Collaborator
|
That's not yours. I'll fix linter issue |
Contributor
Author
Ah fair enough, but I think |
Collaborator
|
Weird. I pushed the fix but still cannot see it on github. Are there any actions needed on your side? |
pashagolub
added a commit
that referenced
this pull request
Nov 15, 2024
supersedes #277 Co-authored-by: Michael Banck <[email protected]>
Collaborator
|
superseded by #278 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAICT,
dcs-type=patronihas usefultrigger-value(200) anddcs-endpoints(http://127.0.0.1:8008) defaults, but none fortrigger-key. The--helpoutput suggests/leader(leaderwithout leading slash works as well), and I am not sure it makes a lot of sense to use anything else than/leader? Or at least, I think that is a useful default, so I implemented it in the attached PR.