Fix PTY serial console#29
Merged
hertrste merged 1 commit intocyberus-technology:gardenlinuxfrom Oct 27, 2025
Merged
Conversation
As we use the write_distributor only if TCP is used, we only add it to the serial out in that case. Not doing so results in e.g. the console not working in the PTY case, because we would overwrite the out member of the serial that was already set before. On-behalf-of: SAP stefan.kober@sap.com Signed-off-by: Stefan Kober <stefan.kober@cyberus-technology.de>
Collaborator
Author
|
See corresponding test: cyberus-technology/libvirt-tests#42 |
hertrste
merged commit c343b19
into
cyberus-technology:gardenlinux
20 of 22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we use the write_distributor only if TCP is used, we only add it to the serial out in that case. Not doing so results in e.g. the console not working in the PTY case, because we would overwrite the out member of the serial that was already set before.