Remove leftover .unwrap()s from TLS code
#59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes all the unwraps from the TLS code to make sure the VMM doesn't panic. On-behalf-of: SAP [email protected] Signed-off-by: Sebastian Eydam <[email protected]>
phip1611
approved these changes
Jan 5, 2026
tpressure
merged commit 451cfb7
into
cyberus-technology:gardenlinux
15 of 16 checks passed
phip1611
added a commit
to phip1611/libvirt-tests
that referenced
this pull request
Jan 6, 2026
This brings [0]. [0] cyberus-technology/cloud-hypervisor#59 On-behalf-of: SAP [email protected] Signed-off-by: Philipp Schuster <[email protected]>
Merged
1 task
github-merge-queue bot
pushed a commit
to cyberus-technology/libvirt-tests
that referenced
this pull request
Jan 6, 2026
This brings [0]. [0] cyberus-technology/cloud-hypervisor#59 On-behalf-of: SAP [email protected] Signed-off-by: Philipp Schuster <[email protected]>
cyberus-renovate
pushed a commit
to cyberus-technology/libvirt
that referenced
this pull request
Jan 6, 2026
This brings [0]. [0] cyberus-technology/cloud-hypervisor#59 On-behalf-of: SAP [email protected] Signed-off-by: Philipp Schuster <[email protected]>
cyberus-renovate
pushed a commit
to cyberus-technology/libvirt
that referenced
this pull request
Jan 7, 2026
This brings [0]. [0] cyberus-technology/cloud-hypervisor#59 On-behalf-of: SAP [email protected] Signed-off-by: Philipp Schuster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all calls to
.unwrap()from the TLS code and replaces them with returned errors. The unwraps that were still there would cause the VMM to panic if any of the expected certificates or keys aren't there.