Save error logs instead of printing #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hertrste
force-pushed
the
dbg-logs
branch
3 times, most recently
from
59f331b to
29b5d4a
Compare
phip1611
reviewed
Jan 8, 2026
phip1611
reviewed
Jan 8, 2026
hertrste
force-pushed
the
dbg-logs
branch
3 times, most recently
from
737ab60 to
bd46d9e
Compare
Instead of printing the logs to stdout in case we have some test failure, we save them to some specified debug log directory. The printing was done to see rar errors in the pipeline that are hard to reproduce locally, but it spammed the logs a lot. Thus, we now switch to saving the logs and the CI can offer them as test artifacts instead. On-behalf-of: SAP [email protected]
On-behalf-of: SAP [email protected]
Contributor
|
Very nice improvment |
tpressure
approved these changes
Jan 8, 2026
phip1611
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in case of an error we print logs from CHV and Libvirt to stdout. This is done to not miss any important information in case we have an test error in the CI.
We replace that behavior and save the log files on the host now. This allows to offer such logs as artifacts in our CI, while it reduces the amount of standard output of the test driver.
The debug log directory can be configured via
DBG_LOG_DIRenvironment variable.