Add plumbing for interface types network and bridge + tests
#106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
network-type-network
branch
from
9fc3c9a to
9bdfb26
Compare
phip1611
changed the title
network and bridge + tests
phip1611
force-pushed
the
network-type-network
branch
from
9bdfb26 to
cce7fef
Compare
Not use anyway as we prefer static IPs in the guest for much quicker boots. Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
phip1611
force-pushed
the
network-type-network
branch
2 times, most recently
from
9af363c to
2d88976
Compare
phip1611
commented
Jan 8, 2026
phip1611
force-pushed
the
network-type-network
branch
2 times, most recently
from
506239e to
a928928
Compare
hertrste
reviewed
Jan 8, 2026
This refactors the hotplug test in a way that it ssh's into the VM
via the hotplugged interface. As a prerequisite, we have to assign
the tap device that libvirt creates into an existing bridge with a
valid IP range. I decided to reuse bridge br0 for that.
To better identify test networks, I also streamlined the MAC
addresses. Now, they match the test IP net:
IP: 192.168.X.0/24 => MAC: ...::0X
192.168.1.0/24 => MAC: ...::01
192.168.2.0/24 => MAC: ...::02
...
A document summarizing all guest/test networks follows in a
subsequent commit.
Signed-off-by: Philipp Schuster <[email protected]>
On-behalf-of: SAP [email protected]
phip1611
force-pushed
the
network-type-network
branch
from
a928928 to
86b5cd4
Compare
Contributor
|
Very very nit, feel free to ignore, but the message of commit "tests: hotplug interface connected to libvirt managed network" contains odd whitespace (double space). From the commit's message: |
This is relevant for interfaces that use the type 'network' in their XML definition. Although not used by OpenStack (they use type 'bridge' which follows later in this PR), it is good to test this. Co-authored-by: Pascal Scholz <[email protected]> Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
phip1611
force-pushed
the
network-type-network
branch
from
86b5cd4 to
248db89
Compare
Adding a network interface of type 'network' that can be hotplugged. Also, using it in the hotplug test. Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
Adding a network interface of type 'bridge' that can be hotplugged. Also, using it in the hotplug test. This is the technology that OpenStack uses for setting up networking. Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
phip1611
force-pushed
the
network-type-network
branch
from
248db89 to
ed8b899
Compare
hertrste
approved these changes
Jan 8, 2026
Collaborator
hertrste
left a comment
hertrste
left a comment
There was a problem hiding this comment.
Looks very nice and concise now :)
scholzp
approved these changes
Jan 8, 2026
Contributor
scholzp
left a comment
scholzp
left a comment
There was a problem hiding this comment.
Nicely done! I especially like that you took the time to write proper documentation of the network setup! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bridge(what OpenStack uses)network(libvirt managed networks)Hints for Reviewers
The table in the last commit (in the markdown document) will help you a lot reviewing this!