-
Notifications
You must be signed in to change notification settings - Fork 5
Add test that reboots a guest during live migration #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tpressure
wants to merge
1
commit into
cyberus-technology:main
Choose a base branch
from
tpressure:reboot_during_live_migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+27
−0
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -1445,6 +1445,32 @@ def test_live_migration_tls(self): | |||||
|
|
||||||
| assert wait_for_ssh(dst) | ||||||
|
|
||||||
| def test_live_migration_with_guest_reboot(self): | ||||||
| """ | ||||||
| Test that a guest induced reboot during live migration keeps the VM | ||||||
| running. The exact semantics need to be sorted out, but at least | ||||||
| CHV and libvirt should handle this situation gracefully. | ||||||
| XXX: the exact semantics of this scenario are TBD | ||||||
| """ | ||||||
|
|
||||||
| controllerVM.succeed("virsh define /etc/domain-chv.xml") | ||||||
| controllerVM.succeed("virsh start testvm") | ||||||
|
|
||||||
| assert wait_for_ssh(controllerVM) | ||||||
|
|
||||||
| status, _ = ssh(controllerVM, "screen -dmS stress stress -m 4 --vm-bytes 400M") | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. obsolete, we now throw exceptions (#121)
Suggested change
|
||||||
| assert status == 0 | ||||||
|
|
||||||
| status, _ = ssh(controllerVM, "screen -dmS nohup sh -c 'sleep 10 && reboot'") | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| assert status == 0 | ||||||
|
|
||||||
| controllerVM.fail( | ||||||
| "virsh migrate --domain testvm --desturi ch+tcp://computeVM/session --persistent --live --p2p" | ||||||
| ) | ||||||
|
|
||||||
| computeVM.fail("virsh list | grep testvm") | ||||||
| controllerVM.succeed("virsh list | grep testvm") | ||||||
|
|
||||||
|
|
||||||
| def suite(): | ||||||
| # Test cases in alphabetical order | ||||||
|
|
@@ -1463,6 +1489,7 @@ def suite(): | |||||
| LibvirtTests.test_live_migration_parallel_connections, | ||||||
| LibvirtTests.test_live_migration_tls, | ||||||
| LibvirtTests.test_live_migration_virsh_non_blocking, | ||||||
| LibvirtTests.test_live_migration_with_guest_reboot, | ||||||
| LibvirtTests.test_live_migration_with_hotplug, | ||||||
| LibvirtTests.test_live_migration_with_hotplug_and_virtchd_restart, | ||||||
| LibvirtTests.test_live_migration_with_hugepages, | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
obsolete, we now throw exceptions (#121)