Skip to content

feat: add access logging to secret fetches#50

Merged
narenaryan merged 3 commits intomainfrom
feat/add-logging
Dec 31, 2025
Merged

feat: add access logging to secret fetches#50
narenaryan merged 3 commits intomainfrom
feat/add-logging

Conversation

@narenaryan
Copy link
Collaborator

@narenaryan narenaryan commented Dec 30, 2025

Description

This PR adds logging to Whispr package while fetching secrets. Log format will be like this:

2025-12-30T23:49:52.158353Z [info ] Secret fetched fetched_at=2025-12-30T23:49:52.158275+00:00 secret_name=my-secretvault_type=aws-ssm

Default logging paths:

  1. Mac OSX: ~/Library/Logs/whispr/access.log
    2.Windows: C:\ProgramData\whispr\access.log
  2. Linux: /var/log/whispr/access.log

@coveralls
Copy link

coveralls commented Dec 30, 2025

Pull Request Test Coverage Report for Build 20608625246

Details

  • 46 of 53 (86.79%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.6%) to 76.168%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/whispr/about.py 0 1 0.0%
src/whispr/aws.py 9 10 90.0%
src/whispr/logging.py 31 36 86.11%
Totals Coverage Status
Change from base Build 16819321292: 1.6%
Covered Lines: 326
Relevant Lines: 428

💛 - Coveralls

@narenaryan narenaryan merged commit 7432ae0 into main Dec 31, 2025
2 checks passed
@narenaryan narenaryan deleted the feat/add-logging branch December 31, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants