Skip to content

Conversation

@vokomarov
Copy link
Contributor

@vokomarov vokomarov commented Feb 6, 2025

🔍 What was changed

Updated types delcaration to explicitly allow nullable where it is implicitly allowed.

🤔 Why?

To prevent deprecation errors while running it on PHP 8.4:

[ErrorException]
Cycle\Migrations\FileRepository::__construct(): Implicitly marking parameter $factory as nullable is deprecated, the explicit nullable type must be used instead
in vendor/cycle/migrations/src/FileRepository.php:42

📝 Checklist

  • How was this tested:
    • Tested manually

Fix MSSQL workflow
@roxblnfk roxblnfk force-pushed the php-8.4-deprecations-fix branch from c4c9e8f to e2262be Compare February 6, 2025 11:42
@roxblnfk roxblnfk force-pushed the php-8.4-deprecations-fix branch from 1b6cabf to f229218 Compare February 6, 2025 11:54
@roxblnfk roxblnfk merged commit 0a99d7f into cycle:4.x Feb 6, 2025
@vokomarov vokomarov deleted the php-8.4-deprecations-fix branch February 6, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants