-
Notifications
You must be signed in to change notification settings - Fork 30
Small AOTF tidy; update mock introspection query response #2239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I am the correct person to review this.
I'm not sure what the introspection query is for, or how I would even test it. Can you give me a little bit more info on this update
The AOTF changes seem fine. I assume that is how you type check in javascript? ugh....I see why type script is a thing.
The introspection query is a GraphQL query that the UI client makes on first load in order to determine the full GraphQL schema of the server, including the GraphQL types. The UI does this here: cylc-ui/src/services/workflow.service.js Line 91 in 298c600
cylc-ui/src/services/workflow.service.js Lines 154 to 181 in 298c600
This is used to populate the command menu when you click on a task icon, as well as all the fields in the form that comes up when you click the pencil/edit button on the menu. The "mock" introspection query response is used to provide this in the "offline"/"mock" mode, which is when you run cylc-ui/src/services/mock/json/README.md Lines 1 to 20 in 298c600
For this PR I ran the full query from the README file on the Cylc 8.5.0 uiserver and overwrote the JSON file with the results. This brings the offline mode up to date. If you feel the developer docs could do with more info anywhere, do shout 👍 |
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.