Skip to content

Fix "Log" & "Info" commands showing for families #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix "Log" & "Info" commands showing for families #2284

wants to merge 2 commits into from
+115 −208

Conversation

MetRonnie
Copy link
Member

  • Log view doesn't apply for families
  • Info view is currently not working for families

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Docs PR not needed

@MetRonnie MetRonnie added this to the 2.9.0 milestone Aug 21, 2025
@MetRonnie MetRonnie self-assigned this Aug 21, 2025
@MetRonnie MetRonnie added the bug Something isn't working label Aug 21, 2025
oliver-sanders
oliver-sanders reviewed Aug 26, 2025
View reviewed changes
src/utils/aotf.js
CyclePoint: 'cycle',
Namespace: 'task',
// Task: 'task',
Family: 'family',
Copy link
Member

@oliver-sanders oliver-sanders Aug 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Namespace is correct, it is ambiguous for task or family, e.g. see cylc broadcast -n & cylc graph -n and the GrpahQL "Namespace*" stuff.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must have a way of distinguishing family commands from task commands.

@MetRonnie MetRonnie modified the milestones: 2.9.0, 2.10.0 Sep 4, 2025
@oliver-sanders oliver-sanders modified the milestones: 2.10.0, 2.11.0 Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@MetRonnie MetRonnie

Labels
bug Something isn't working
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MetRonnie @oliver-sanders