workflows: add is_retry and is_held indicators#2378
Merged
wxtim merged 8 commits intocylc:masterfrom Jan 5, 2026
Merged
Conversation
8 tasks
oliver-sanders
commented
Dec 11, 2025
Comment on lines
+33
to
+34
| export const taskRetry = 'm14.7 2.5c-0.179-0.0044-0.358-0.0037-0.538 0.0021-0.958 0.031-1.92 0.208-2.86 0.539-3.3 1.17-5.65 4.05-6.2 7.44l-5.13-1.23 6.86 9.23 6.86-9.23-5.35 1.19c0.511-2.02 2-3.69 4.02-4.41 2.5-0.886 5.28-0.124 6.98 1.91 1.7 2.04 1.95 4.91 0.625 7.21-1.32 2.3-3.93 3.53-6.54 3.09a1.58 1.58 0 0 0-1.82 1.3 1.58 1.58 0 0 0 1.3 1.82c3.91 0.661 7.84-1.19 9.81-4.63 1.98-3.44 1.6-7.76-0.938-10.8-1.79-2.14-4.39-3.35-7.07-3.41z' | ||
| export const taskHeld = 'm12 0.5c-6.34 0-11.5 5.17-11.5 11.5-1.9e-7 6.33 5.16 11.5 11.5 11.5 6.34 0 11.5-5.17 11.5-11.5 0-6.33-5.16-11.5-11.5-11.5zm0 2.74c4.85 0 8.76 3.9 8.76 8.76 0 4.85-3.9 8.76-8.76 8.76-4.85 0-8.76-3.9-8.76-8.76 0-4.85 3.9-8.76 8.76-8.76zm-3.2 2.36a2.05 2.05 0 0 0-2.05 2.05v8.7a2.05 2.05 0 0 0 2.05 2.05 2.05 2.05 0 0 0 2.05-2.05v-8.7a2.05 2.05 0 0 0-2.05-2.05zm6.4 0a2.05 2.05 0 0 0-2.05 2.05v8.7a2.05 2.05 0 0 0 2.05 2.05 2.05 2.05 0 0 0 2.05-2.05v-8.7a2.05 2.05 0 0 0-2.05-2.05z' |
Member
Author
There was a problem hiding this comment.
These are icons derived directly from the task modifiers in the SVGTask component which were transformed into the Vuetify icon format (single path, 24px square dimensions).
For info, quick runthrough of how to do this:
- Extract SVG as start point, save as file.
- Open in Inkscape.
- Apply configured CSS to objects.
- Convert objects to paths.
- Unify all paths into a single path.
- Rescale down to 24x24px.
- Export as optimised CSS.
- Reduce the sig fig precision until it breaks (3 in this case).
- Copy path (the
d="..."bit) out of exported SVG.
I did export the transformed retry modifier pre-scaling.
This diff applies it to the `SVGTask`:
diff --git a/src/components/cylc/SVGTask.vue b/src/components/cylc/SVGTask.vue
index 43b6f1db..e5eca12c 100644
--- a/src/components/cylc/SVGTask.vue
+++ b/src/components/cylc/SVGTask.vue
@@ -231,10 +231,18 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
Circular arrow representing a retry.
-->
<g class="retry">
- <!-- An arc describing the arrow -->
- <path d="m25, 50 a30 30 1 1 1 25 30 "/>
- <!-- The arrowhead -->
- <polygon points="0,40 26,75 52,40, 25,46"/>
+ <path d="m55.8 14.4c-0.679-0.0166-1.36-0.0142-2.04 0.00781-3.63 0.117-7.28 0.787-10.8 2.04-12.5 4.43-21.4 15.4-23.5 28.2l-19.5-4.67 26 35 26-35-20.3 4.5c1.94-7.65 7.57-14 15.2-16.7 9.49-3.36 20-0.471 26.4 7.26 6.44 7.73 7.39 18.6 2.37 27.3-5.01 8.72-14.9 13.4-24.8 11.7a6 6 0 0 0-6.92 4.92 6 6 0 0 0 4.92 6.92c14.8 2.51 29.7-4.51 37.2-17.6 7.5-13 6.07-29.4-3.56-41-6.77-8.13-16.6-12.7-26.8-12.9z"/>
+ <!--
+ The path above is an optimised reuduction of:
+
+ An arc describing the arrow:
+ <path d="m25, 50 a30 30 1 1 1 25 30 " style="stroke-linecap="round"; stroke: 12px;" />
+ The arrowhead:
+ <polygon points="0,40 26,75 52,40, 25,46"/>
+
+ Created by converting both objects to paths, combining them, then
+ optmising.
+ -->
</g>
<!-- Wallclock
@@ -542,12 +550,6 @@ const modifierTransform = _getModifierTransform()
&.retry .modifier {
.retry path {
- stroke: $foreground;
- stroke-width: 12px;
- stroke-linecap: round;
- }
- .retry polygon {
- stroke: none;
fill: $foreground;
}
}However, I didn't include that in this PR because:
- Unnecessary change right now!
- Less maintainable (although it's pretty static, so maybe that doesn't matter).
- Profiling required to determine whether this is more efficient (what takes longer, the DOM or bezier maths?).
Member
There was a problem hiding this comment.
Member
Member
|
I've made a PR to this PR oliver-sanders#123 containing a test. |
wxtim
reviewed
Dec 16, 2025
Member
wxtim
left a comment
There was a problem hiding this comment.
- Read code
- Tried it manually
- Wrote test oliver-sanders#123
wxtim
approved these changes
Dec 16, 2025
* Closes cylc#2350 * Adds workflow indicator icons which appear if the workflow contains any tasks in the retry and held states.
955ac5a to
e1d2613
Compare
Small optimisation: do not render tooltips until hover
MetRonnie
reviewed
Dec 17, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Member
Never mind, it turned out I needed to pull 8.6.x to bring in cylc/cylc-flow#7138 and restart my UI server |
Member
Author
|
(phew) |
MetRonnie
approved these changes
Dec 18, 2025
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
MetRonnie
approved these changes
Dec 19, 2025
This comment was marked as resolved.
This comment was marked as resolved.
MetRonnie
approved these changes
Jan 5, 2026
Member
|
@wxtim some changes since your last review |
wxtim
approved these changes
Jan 5, 2026
oliver-sanders
added a commit
to oliver-sanders/cylc-uiserver
that referenced
this pull request
Jan 7, 2026
* Ensures that new data elements added in cylc/cylc-flow#7138 are available for the bundled UI version which will include cylc/cylc-ui#2378
MetRonnie
pushed a commit
to cylc/cylc-uiserver
that referenced
this pull request
Jan 7, 2026
* Ensures that new data elements added in cylc/cylc-flow#7138 are available for the bundled UI version which will include cylc/cylc-ui#2378
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Requires:
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.