Skip to content

Conversation

khawjaahmad
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Sep 26, 2024

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit fa44955

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2024

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399

This comment was marked as resolved.

@MikeMcC399

This comment was marked as resolved.

@khawjaahmad
Copy link
Contributor Author

@MikeMcC399

I have done the changes as requested and marked the issues closed. Also updated the plugin entry in the correct order.
Thanks

Copy link
Contributor Author

@khawjaahmad khawjaahmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes addressed.

@MikeMcC399
Copy link
Contributor

@khawjaahmad

I have done the changes as requested and marked the issues closed. Also updated the plugin entry in the correct order.

Thank you for the confirmation. Your npm module now looks in good shape.

You will need to wait for re-review by the Cypress.io team now. (As an external contributor I don't have privileges to merge your content.)

@jennifer-shehane jennifer-shehane merged commit 6b5a134 into cypress-io:main Oct 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants