Skip to content

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Oct 24, 2024

DO NOT MERGE

Dependent on cypress-io/cypress#30305 being released

@cypress
Copy link

cypress bot commented Oct 24, 2024

cypress-documentation    Run #272

Run Properties:  status check passed Passed #272  •  git commit 6ea5dc5505: chore: make sure prettier doesnt run on these lines as things look quite odd (#6...
Project cypress-documentation
Branch Review release/14.0.0
Run status status check passed Passed #272
Run duration 06m 46s
Commit git commit 6ea5dc5505: chore: make sure prettier doesnt run on these lines as things look quite odd (#6...
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 290
View all changes introduced in this branch ↗︎
UI Coverage  10.94%
  Untested elements 2307  
  Tested elements 3  
Accessibility  96.85%
  Failed rules  0 critical   4 serious   4 moderate   0 minor
  Failed elements 433  

@jennifer-shehane
Copy link
Member Author

Fixed new conflicts

Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added several comments in-line

Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just one outstanding very minor grammar suggestion.

@AtofStryker AtofStryker merged commit 639cfea into main Jan 16, 2025
10 checks passed
@AtofStryker AtofStryker deleted the release/14.0.0 branch January 16, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants