Skip to content

Conversation

@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Nov 5, 2024

@jennifer-shehane jennifer-shehane self-assigned this Nov 5, 2024
@cypress
Copy link

cypress bot commented Nov 5, 2024

cypress-documentation    Run #88

Run Properties:  status check passed Passed #88  •  git commit 65088a44c9: Merge branch 'main' into test-replay-refresh
Project cypress-documentation
Branch Review test-replay-refresh
Run status status check passed Passed #88
Run duration 03m 56s
Commit git commit 65088a44c9: Merge branch 'main' into test-replay-refresh
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 279
View all changes introduced in this branch ↗︎
UI Coverage  10.92%
  Untested elements 1795  
  Tested elements 3  
Accessibility  95.68%
  Failed rules  2 critical   5 serious   4 moderate   0 minor
  Failed elements 582  

- Audio ([see issue](https://github.com/cypress-io/cypress/issues/29905))
- Objects that do not have `type="image/svg+xml"` ([see issue](https://github.com/cypress-io/cypress/issues/29904))
- Shadow DOM with `slotAssignment="manual"` ([see issue](https://github.com/cypress-io/cypress/issues/29107))
- Shadow DOM canvas ([see issue](https://github.com/cypress-io/cypress/issues/30438))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Shadow DOM canvas ([see issue](https://github.com/cypress-io/cypress/issues/30438))
- Shadow DOM canvases ([see issue](https://github.com/cypress-io/cypress/issues/30438))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated here to be more specific on plurality and elements vs other things 56e77c8 (#5985)

- Web sockets ([see issue](https://github.com/cypress-io/cypress/issues/29907))
- localStorage & sessionStorage ([see issue](https://github.com/cypress-io/cypress/issues/29909))
- Cookies ([see issue](https://github.com/cypress-io/cypress/issues/29910))
- Console props of Cypress commands outside of `cy.request()` ([see issue](https://github.com/cypress-io/cypress/issues/29911))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to call out that we do not capture network traffic of cy.request() either?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed here 7ec343a (#5985) I created a public issue to track this also.

@AtofStryker AtofStryker self-requested a review November 6, 2024 23:14

:::info

**Tip:** We recommend disabling video recording when recording with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it clear that video is disabled by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are so many customers I've seen that have it on, I do think it needs to be called out very explicitly.

@jennifer-shehane jennifer-shehane merged commit 4a03a0f into main Nov 7, 2024
10 checks passed
@jennifer-shehane jennifer-shehane deleted the test-replay-refresh branch November 7, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants