refactor: improve DarkModeSwitch theme handling #6033
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for cypress-docs pending review.Visit the deploys page to approve it
|
|
|
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+11
to
+16
| useEffect(() => { | ||
| const savedTheme = localStorage.getItem('theme') | ||
| if (savedTheme !== colorMode) { | ||
| setColorMode(savedTheme) | ||
| } | ||
| }, [colorMode, setColorMode]) |
There was a problem hiding this comment.
The current dependency array [colorMode, setColorMode] will trigger the effect whenever colorMode changes, which can create an infinite loop since the effect itself updates colorMode. Since this effect only needs to run once to initialize the theme from localStorage, the dependency array should be []. This will ensure the effect runs only when the component mounts.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.