fix: Update styles for dark backgrounds to be readable #6066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress-documentation
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress-documentation
|
| Branch Review |
card-dark-bg-fix
|
| Run status |
|
| Run duration | 06m 12s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
290
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
11.12%
|
|
|---|---|
|
Untested elements
|
2265
|
|
Tested elements
|
3
|
Accessibility
95.89%
|
|
|---|---|
|
Failed rules
|
2 critical
5 serious
4 moderate
0 minor
|
|
Failed elements
|
687
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the new changes were not displaying well in dark mode. I've updated them to be more readable.
Additionally, this fixes the tests so that they truly visit all URLs and that all URLs are visited in dark mode (so we could see any decrease in Accessibility scores for light and dark mode).
Accessibility Report: https://cloud.cypress.io/projects/imown1/runs/230/accessibility
Before
After