Skip to content

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Feb 21, 2025

This signature is just...wrong. I looked at the implementation. The .shadow command does not accept a selector.

Also added the options that are supported.

@jennifer-shehane jennifer-shehane self-assigned this Feb 21, 2025
@cypress
Copy link

cypress bot commented Feb 21, 2025

cypress-documentation    Run #305

Run Properties:  status check passed Passed #305  •  git commit c405584787: lint
Project cypress-documentation
Branch Review fix-shadow-command
Run status status check passed Passed #305
Run duration 09m 25s
Commit git commit c405584787: lint
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 297
View all changes introduced in this branch ↗︎
UI Coverage  11.02%
  Untested elements 2344  
  Tested elements 3  
Accessibility  96.93%
  Failed rules  1 critical   4 serious   4 moderate   0 minor
  Failed elements 28  

@jennifer-shehane jennifer-shehane merged commit 94deb32 into main Feb 21, 2025
10 checks passed
@jennifer-shehane jennifer-shehane deleted the fix-shadow-command branch February 21, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants