Skip to content

fix: Google Chrome for testing - version not parsed correctly #28243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

fix: Google Chrome for testing - version not parsed correctly #28243

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
46843e9
fix: Google Chrome for testing - version not parsed correctly
Crustum7 Nov 5, 2023
4dea468
Merge branch 'develop' into issue-28123
Crustum7 Dec 8, 2023
9a3eede
Merge branch 'develop' into issue-28123
jennifer-shehane Dec 12, 2023
c7f701d
Merge branch 'develop' into issue-28123
jennifer-shehane Aug 19, 2024
2cbe17a
Merge branch 'develop' into issue-28123
AtofStryker Nov 18, 2024
5dd3010
update changelog
AtofStryker Nov 18, 2024
33223b6
Merge branch 'develop' into issue-28123
mschile Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cli/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ _Released 11/19/2024 (PENDING)_
**Bugfixes:**

- Fixed an issue where some JS assets were not properly getting sourcemaps included with the vite dev server if they had a cache busting query parameter in the URL. Fixed some scenarios to ensure that the sourcemaps that were included by the vite dev server were inlined. Addressed in [#30606](https://github.com/cypress-io/cypress/pull/30606).
- Fixed Google Chrome for Testing version not parsing correctly. Fixes [#28123](https://github.com/cypress-io/cypress/issues/28123).

## 13.15.2

Expand Down
3 changes: 2 additions & 1 deletion packages/launcher/lib/known-browsers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ export const knownBrowsers: Browser[] = [
family: 'chromium',
channel: 'stable',
displayName: 'Chrome',
versionRegex: /Google Chrome (\S+)/m,
// Chrome for testing can be any stable, beta, dev or canary version
versionRegex: /Google Chrome (?:for Testing )?(\S+)/m,
binary: ['google-chrome', 'chrome', 'google-chrome-stable'],
minSupportedVersion: MIN_CHROME_VERSION,
},
Expand Down