-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat: ability to specify the default browser in cypress config #30517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
44e0c99
feat: ability to specify the default browser in cypress config file
alexsch01 24e3dda
don't need setActiveBrowserByNameOrPath for run mode
alexsch01 f8789ab
restore readonly on attribute
alexsch01 2f82876
simplify cypress open version
alexsch01 11bd244
put isBrowserGivenByCli on modeOptions (#4)
alexsch01 c1fc1b2
Update cypress.d.ts
alexsch01 66d26b1
use isBrowserGivenByCli only for run mode (#5)
alexsch01 d4a68ba
make defaultBrowser more conformant
alexsch01 8028e51
Update CHANGELOG.md
alexsch01 77ffd7a
Update CHANGELOG.md
alexsch01 5d6202d
Update CHANGELOG.md
alexsch01 17c40b3
Merge branch 'develop' into defaultBrowser-config
jennifer-shehane d036d96
oops (#6)
alexsch01 08fb3a3
Merge branch 'develop' into defaultBrowser-config
jennifer-shehane 7aaf2a9
changes (#7)
alexsch01 b7cb459
more test fixes (#8)
alexsch01 ea67832
Update utils.spec.ts
alexsch01 4f1cd4d
Update packages/config/src/options.ts
alexsch01 7154055
Update cli/CHANGELOG.md
alexsch01 9a740c4
Update cli/types/cypress.d.ts
alexsch01 2dddf0f
Update packages/config/src/options.ts
alexsch01 5f1d6b9
Update packages/data-context/src/data/ProjectLifecycleManager.ts
alexsch01 adec731
Update DataContext.ts
alexsch01 4425433
Update DataContext.ts
alexsch01 6933638
final oops
alexsch01 2a53ba0
remove requireRestartOnChange for defaultBrowser, prevent bad open mo…
alexsch01 fd9c123
oops
alexsch01 4465303
organization changes (#10)
alexsch01 072ca63
fixed
alexsch01 9e88d67
if activeBrowser is already set, make sure the label is correct
alexsch01 acad76a
oops
alexsch01 973932c
Update ProjectLifecycleManager.spec.ts
alexsch01 61071cf
Update ProjectLifecycleManager.spec.ts
alexsch01 683d2a9
Merge branch 'develop' into defaultBrowser-config
alexsch01 1beecad
Update CHANGELOG.md
alexsch01 ea704aa
Update CHANGELOG.md
alexsch01 fb000df
Update CHANGELOG.md
alexsch01 e3c754d
hopefully fix lint, add to test
alexsch01 f550b4c
Update ProjectLifecycleManager.spec.ts
alexsch01 75c30d2
Update ProjectLifecycleManager.spec.ts
alexsch01 337bfb5
Update ProjectLifecycleManager.spec.ts
alexsch01 d6f72b6
more accurate
alexsch01 3371d54
Update CHANGELOG.md
alexsch01 92fc352
pr updates
mschile 6b8fad3
Merge branch 'develop' into defaultBrowser-config
alexsch01 c859819
a few more updates
mschile 959efeb
fix cy-in-cy tests
mschile 3d5cd9d
can once again pass --browser CLI in open mode
alexsch01 1bed710
Update CHANGELOG.md
alexsch01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
system-tests/projects/config-defaultBrowser/cypress.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| module.exports = { | ||
| e2e: { | ||
| supportFile: false, | ||
| }, | ||
| defaultBrowser: 'chrome', | ||
| } |
3 changes: 3 additions & 0 deletions
3
system-tests/projects/config-defaultBrowser/cypress/e2e/spec.cy.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| it('works', () => { | ||
| expect(1).to.eq(1) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.