Skip to content

Conversation

@XavierBoubert
Copy link

  • Closes

Additional details

This PR introduces the standard log: boolean option used in many commands to hide the cy.origin() log. It's the only one log that I can't hide in my enterprise tests framework.

Steps to test

Use the new log option in cy.origin to test it:

cy.origin('https://example.com', { args: { /* ... */, log: false }, () => {
  // ...
});

How has the user experience changed?

There is no Breaking change here. You experience changes uniquely if you want to hide some logs.

Very useful in SSO logins for example.

PR Tasks

@CLAassistant
Copy link

CLAassistant commented Feb 16, 2025

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@jennifer-shehane
Copy link
Member

@XavierBoubert We'll have to discuss if this is a feature we want to support. Thanks for contributing!

@XavierBoubert
Copy link
Author

@jennifer-shehane Do you have any news?

@XavierBoubert
Copy link
Author

@jennifer-shehane up?

@jennifer-shehane
Copy link
Member

@XavierBoubert We've had some conversations about this in the past and felt this did complicate the display of commands in the command log, with the parent log being hidden and the children possibly still displaying. Can you provide an example screenshot of what the logs look like if you've hidden cy.origin, but none of the children commands?

@jennifer-shehane jennifer-shehane self-requested a review March 11, 2025 14:46
@jennifer-shehane
Copy link
Member

Going to close as stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants