-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat: Add Cypress.stop types to document its availability more publicly #31225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cypress
|
Project |
cypress
|
Branch Review |
cypress-stop-types
|
Run status |
|
Run duration | 18m 44s |
Commit |
|
Committer | Jennifer Shehane |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
14
|
|
1232
|
|
0
|
|
32101
|
View all changes introduced in this branch ↗︎ |
UI Coverage
46.31%
|
|
---|---|
|
184
|
|
163
|
Accessibility
92.56%
|
|
---|---|
|
3 critical
8 serious
2 moderate
2 minor
|
|
878
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the cancelation spec is probably enough for tests for this, right?
@AtofStryker Yah I looked through the tests and there seemed to be tests around it. |
…s availability more publicly (#31225)
…availability more publicly (#31225)
…s availability more publicly (#31225)
…availability more publicly (#31225)
…s availability more publicly (#31225)
…availability more publicly (#31225)
…s availability more publicly (#31225)
…availability more publicly (#31225)
…s availability more publicly (#31225)
…availability more publicly (#31225)
…s availability more publicly (#31225)
…availability more publicly (#31225)
* chore: updating v8 snapshot cache * index on develop: 667e319 feat: Add Cypress.stop types to document its availability more publicly (#31225) * index on develop: 667e319 feat: Add Cypress.stop types to document its availability more publicly (#31225) --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
* chore: updating v8 snapshot cache * index on develop: 667e319 feat: Add Cypress.stop types to document its availability more publicly (#31225) * index on develop: 667e319 feat: Add Cypress.stop types to document its availability more publicly (#31225) --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
* chore: updating v8 snapshot cache * index on develop: 667e319 feat: Add Cypress.stop types to document its availability more publicly (#31225) * index on develop: 667e319 feat: Add Cypress.stop types to document its availability more publicly (#31225) --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Close #518
Additional details
Since an issue with Test Replays not working with
Cypress.stop
have now been addressed, we will be publicly documentingCypress.stop()
and want to have official types available as well. Documentation PR: cypress-io/cypress-documentation#6115Steps to test
Use Cypress.stop, see there are no ts warnings
How has the user experience changed?
Before
After
PR Tasks
cypress-documentation
?type definitions
?