Skip to content

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Mar 6, 2025

Close #518

Additional details

Since an issue with Test Replays not working with Cypress.stop have now been addressed, we will be publicly documenting Cypress.stop() and want to have official types available as well. Documentation PR: cypress-io/cypress-documentation#6115

Steps to test

Use Cypress.stop, see there are no ts warnings

How has the user experience changed?

Before

Screenshot 2025-03-07 at 9 31 49 AM

After

Screenshot 2025-03-07 at 9 31 35 AM

PR Tasks

@jennifer-shehane jennifer-shehane self-assigned this Mar 6, 2025
@jennifer-shehane jennifer-shehane changed the title misc: Add types for Cypress.stop feat: Add Cypress.stop types to document its availability more publicly Mar 7, 2025
Copy link

cypress bot commented Mar 7, 2025

cypress    Run #60769

Run Properties:  status check passed Passed #60769  •  git commit 914ab415c3: Merge branch 'develop' into cypress-stop-types
Project cypress
Branch Review cypress-stop-types
Run status status check passed Passed #60769
Run duration 18m 44s
Commit git commit 914ab415c3: Merge branch 'develop' into cypress-stop-types
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 14
Tests that did not run due to a developer annotating a test with .skip  Pending 1232
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 32101
View all changes introduced in this branch ↗︎
UI Coverage  46.31%
  Untested elements 184  
  Tested elements 163  
Accessibility  92.56%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 878  

@AtofStryker AtofStryker self-requested a review March 7, 2025 15:00
Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the cancelation spec is probably enough for tests for this, right?

@jennifer-shehane
Copy link
Member Author

@AtofStryker Yah I looked through the tests and there seemed to be tests around it.

@jennifer-shehane jennifer-shehane merged commit 667e319 into develop Mar 7, 2025
85 of 90 checks passed
@jennifer-shehane jennifer-shehane deleted the cypress-stop-types branch March 7, 2025 17:43
cypress-app-bot pushed a commit that referenced this pull request Mar 9, 2025
cypress-app-bot pushed a commit that referenced this pull request Mar 9, 2025
cypress-app-bot pushed a commit that referenced this pull request Mar 9, 2025
cypress-app-bot pushed a commit that referenced this pull request Mar 9, 2025
cypress-app-bot pushed a commit that referenced this pull request Mar 9, 2025
cypress-app-bot pushed a commit that referenced this pull request Mar 9, 2025
cypress-app-bot pushed a commit that referenced this pull request Mar 10, 2025
cypress-app-bot pushed a commit that referenced this pull request Mar 10, 2025
cypress-app-bot pushed a commit that referenced this pull request Mar 10, 2025
cypress-app-bot pushed a commit that referenced this pull request Mar 10, 2025
cypress-app-bot pushed a commit that referenced this pull request Mar 10, 2025
cypress-app-bot pushed a commit that referenced this pull request Mar 10, 2025
jennifer-shehane pushed a commit that referenced this pull request Mar 10, 2025
* chore: updating v8 snapshot cache

* index on develop: 667e319 feat: Add Cypress.stop types to document its availability more publicly (#31225)

* index on develop: 667e319 feat: Add Cypress.stop types to document its availability more publicly (#31225)

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
jennifer-shehane pushed a commit that referenced this pull request Mar 10, 2025
* chore: updating v8 snapshot cache

* index on develop: 667e319 feat: Add Cypress.stop types to document its availability more publicly (#31225)

* index on develop: 667e319 feat: Add Cypress.stop types to document its availability more publicly (#31225)

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
jennifer-shehane pushed a commit that referenced this pull request Mar 10, 2025
* chore: updating v8 snapshot cache

* index on develop: 667e319 feat: Add Cypress.stop types to document its availability more publicly (#31225)

* index on develop: 667e319 feat: Add Cypress.stop types to document its availability more publicly (#31225)

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 12, 2025

Released in 14.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v14.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to abort on first failure

2 participants