Skip to content

chore: fix pre-release download for win32-arm64 #31836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025
Merged

chore: fix pre-release download for win32-arm64 #31836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
619a71a
chore: fix pre-release download for win32-arm64
MikeMcC399 Jun 6, 2025
aac4813
Merge branch 'develop' into issue-31831-win32-arm-pre-release
MikeMcC399 Jun 6, 2025
186d160
add unit test win32-arm64 to win32-x64 for pre-release
MikeMcC399 Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion cli/lib/tasks/install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,15 @@ const verbose = require('../VerboseRenderer')
const { buildInfo, version } = require('../../package.json')

function _getBinaryUrlFromBuildInfo (arch, { commitSha, commitBranch }) {
return `https://cdn.cypress.io/beta/binary/${version}/${os.platform()}-${arch}/${commitBranch}-${commitSha}/cypress.zip`
const platform = os.platform()

if ((platform === 'win32') && (arch === 'arm64')) {
debug(`detected platform ${platform} architecture ${arch} combination`)
arch = 'x64'
debug(`overriding to download ${platform}-${arch} pre-release binary instead`)
}

return `https://cdn.cypress.io/beta/binary/${version}/${platform}-${arch}/${commitBranch}-${commitSha}/cypress.zip`
}

const alreadyInstalledMsg = () => {
Expand Down
7 changes: 7 additions & 0 deletions cli/test/lib/tasks/install_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,5 +502,12 @@ describe('/lib/tasks/install', function () {
expect(install._getBinaryUrlFromBuildInfo('x64', buildInfo))
.to.eq(`https://cdn.cypress.io/beta/binary/0.0.0-development/linux-x64/aBranchName-abc123/cypress.zip`)
})

it('overrides win32-arm64 to win32-x64 for pre-release', () => {
os.platform.returns('win32')

expect(install._getBinaryUrlFromBuildInfo('arm64', buildInfo))
.to.eq(`https://cdn.cypress.io/beta/binary/0.0.0-development/win32-x64/aBranchName-abc123/cypress.zip`)
})
})
})