breaking: Move getSelector and reset to private methods on ElementSelector API

cli/types/cypress.d.ts

@@ -702,7 +702,6 @@ declare namespace Cypress {
      */
     ElementSelector: {
       defaults(options: Partial<ElementSelectorDefaultsOptions>): void
-      getSelector($el: JQuery): JQuery.Selector
     }
 
     /**

packages/app/src/runner/aut-iframe.ts

@@ -385,7 +385,7 @@ export class AutIframe {
 
     const Cypress = this.eventManager.getCypress()
 
-    const selector = Cypress.ElementSelector.getSelector($el)
+    const selector = Cypress.ElementSelector._getSelector($el)
     const selectorPlaygroundStore = useSelectorPlaygroundStore()
 
     this._addOrUpdateSelectorPlaygroundHighlight({

packages/app/src/store/studio-store.ts

@@ -520,7 +520,7 @@ export const useStudioStore = defineStore('studioRecorder', {
       if (!this._matchPreviousMouseEvent(target)) {
         this._previousMouseEvent = {
           element: target,
-          selector: getCypress().ElementSelector.getSelector(window.UnifiedRunner.CypressJQuery(target)),
+          selector: getCypress().ElementSelector._getSelector(window.UnifiedRunner.CypressJQuery(target)),
         }
       }
     },

packages/driver/cypress/e2e/cypress/element_selector.cy.ts

@@ -2,13 +2,17 @@
 import type { ElementSelectorAPI } from '../../../src/cypress/element_selector'
 import { DEFAULT_SELECTOR_PRIORITIES } from '../../../src/cypress/element_selector'
 const { $: $cypress } = Cypress.$Cypress
-const ElementSelector = Cypress.ElementSelector as ElementSelectorAPI
+const ElementSelector = Cypress.ElementSelector as ElementSelectorAPI & {
+  _reset(): void
+  getSelectorPriority(): Cypress.SelectorPriority[]
+  _getSelector($el: any): string
+}
 
 const SELECTOR_DEFAULTS: Cypress.SelectorPriority[] = [...DEFAULT_SELECTOR_PRIORITIES]
 
 describe('src/cypress/element_selector', () => {
   beforeEach(() => {
-    ElementSelector.reset()
+    ElementSelector._reset()
   })
 
   it('has defaults', () => {
@@ -108,13 +112,13 @@ describe('src/cypress/element_selector', () => {
 
       Cypress.$('body').append($div)
 
-      expect(ElementSelector.getSelector($div)).to.eq('[data-cy="main button 123"]')
+      expect(ElementSelector._getSelector($div)).to.eq('[data-cy="main button 123"]')
 
       ElementSelector.defaults({
         selectorPriority: ['data-foo'],
       })
 
-      expect(ElementSelector.getSelector($div)).to.eq('[data-foo="bar"]')
+      expect(ElementSelector._getSelector($div)).to.eq('[data-foo="bar"]')
     })
   })
 

packages/driver/src/cypress/element_selector.ts

@@ -29,10 +29,13 @@ export type ElementSelectorDefaultsOptions = {
 }
 
 export interface ElementSelectorAPI {
-  reset(): void
-  getSelectorPriority(): Cypress.SelectorPriority[]
-  getSelector($el: any): string
   defaults(options: ElementSelectorDefaultsOptions): void
+  getSelectorPriority(): Cypress.SelectorPriority[]
+}
+
+interface ElementSelectorPrivate {
+  _reset(): void
+  _getSelector($el: any): string
 }
 
 const reset = (): Defaults => {
@@ -43,21 +46,21 @@ const reset = (): Defaults => {
 
 let defaults = reset()
 
-const ElementSelector: ElementSelectorAPI = {
-  reset () {
+const ElementSelector: ElementSelectorAPI & ElementSelectorPrivate = {
+  _reset () {
     defaults = reset()
   },
 
-  getSelectorPriority () {
-    return defaults.selectorPriority
-  },
-
-  getSelector ($el: any) {
+  _getSelector ($el: any) {
     return uniqueSelector($el.get(0), {
       selectorTypes: defaults.selectorPriority,
     })
   },
 
+  getSelectorPriority () {
+    return defaults.selectorPriority
+  },
+
   defaults (props: ElementSelectorDefaultsOptions) {
     if (!_.isPlainObject(props)) {
       $errUtils.throwErrByPath('element_selector.defaults_invalid_arg', {