Fix: Redirect spammy electron stderr to a debug sink #32188
Draft
+2,900
−437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
fix/audio-error-stdout
|
| Run status |
|
| Run duration | 20m 03s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
12
|
Pending
|
1102
|
Skipped
|
0
|
Passing
|
26527
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
44.86%
|
|
|---|---|
|
Untested elements
|
188
|
|
Tested elements
|
157
|
Accessibility
97.71%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
110
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Rather than maintaining an ever-growing list of regular expressions to filter electron stderr output, I've opted to provide a holistic approach:
The errors lib now exports a few utility transform streams, and an error logging function. When the utility streams are used in conjunction with the tags that are exported alongside the error logging function, parent processes can effectively split "first party" stderr output from "third party" stderr output.
This is a draft PR. Unit tests, removing obsolete tests, and full migration from console.error -> logError are pending vs. confirmation of approach.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?