feat: escape key for cy.press #32545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
feat/key-press-esc
|
| Run status |
|
| Run duration | 10m 35s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
3
|
Skipped
|
0
|
Passing
|
941
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
40.07%
|
|
|---|---|
|
Untested elements
|
181
|
|
Tested elements
|
121
|
Accessibility
97.9%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
1 moderate
2 minor
|
|
Failed elements
|
73
|
AtofStryker
approved these changes
Sep 23, 2025
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cy.press#32429Additional details
Adds the
Escapekey to the support keys. This list of supported keys is necessary because some need to be overridden with specific unicode codepoints in Webdriver BiDi.Steps to test
Use
cy.press(Cypress.Keyboard.Keys.ESC), and assert that the escape key is pressed.How has the user experience changed?
PR Tasks
cypress-documentation? docs: add escape key to supported key.press() named keys cypress-documentation#6279type definitions?