-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat: --posix-exit-codes
cli flag in run mode
#32609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6f3bd5d
pass posix exit code to server
cacieprins afa0951
return 1 if any tests fail and posix exit codes are enabled
cacieprins f81cac4
changelog
cacieprins 401ba89
Merge branch 'develop' into feat-32485-posix-exit-codes
cacieprins 7509dee
rm .only
cacieprins 8208080
snapshot
cacieprins a36158e
changelog
cacieprins 95ce5ad
update typedef
cacieprins c5f18e8
Merge branch 'develop' into feat-32605-posix-exit-codes
cacieprins 14f40d0
changelog
cacieprins ac72693
Merge branch 'develop' into feat-32605-posix-exit-codes
cacieprins fffb3ff
Update cli/CHANGELOG.md
cacieprins 8824abe
lift disabled posix system test to different desc block
cacieprins 640f786
add posix-exit-codes in lib/exec/run.ts#processRunOptions
cacieprins 9adaaec
Merge branch 'develop' into feat-32605-posix-exit-codes
cacieprins 4696ca3
Apply suggestion from @jennifer-shehane
cacieprins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import systemTests from '../lib/system-tests' | ||
|
||
describe('posix exit codes', () => { | ||
systemTests.setup() | ||
|
||
describe('when posix exit codes are enabled', () => { | ||
systemTests.it('returns 1 when there are failing tests', { | ||
cacieprins marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
spec: 'simple_failing.cy.js', | ||
posixExitCodes: true, | ||
expectedExitCode: 1, | ||
browser: ['electron'], | ||
project: 'e2e', | ||
}) | ||
|
||
systemTests.it('returns 2 when there are 2 failing tests and posix is disabled', { | ||
cacieprins marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
spec: 'simple_failing.cy.js', | ||
posixExitCodes: false, | ||
expectedExitCode: 2, | ||
browser: ['electron'], | ||
project: 'e2e', | ||
}) | ||
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
systemTests.it('returns 0 when there are no failing tests', { | ||
spec: 'simple_passing.cy.js', | ||
posixExitCodes: true, | ||
expectedExitCode: 0, | ||
browser: ['electron'], | ||
project: 'e2e', | ||
}) | ||
}) | ||
}) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.