Skip to content
Open
Show file tree
Hide file tree
Changes from 15 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .circleci/src/pipeline/@pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ ubuntu-2004-current: &ubuntu-2004-current ubuntu-2004:2024.11.1
ubuntu-2004-older: &ubuntu-2004-older ubuntu-2004:2024.05.1

orbs:
browser-tools: circleci/browser-tools@2.1.1
browser-tools: circleci/browser-tools@2.3.1

defaults: &defaults
parallelism: 1
Expand Down Expand Up @@ -563,6 +563,7 @@ commands:
# https://www.ubuntuupdates.org/package/google_chrome/stable/main/base/google-chrome-stable
channel: << parameters.google-chrome-channel >>
chrome_version: << parameters.google-chrome-version >>
replace_existing: true
- when:
condition:
equal: [ 'beta', << parameters.google-chrome-channel>> ]
Expand Down Expand Up @@ -1786,7 +1787,7 @@ jobs:
source ./scripts/ensure-node.sh
yarn lerna run types
- sanitize-verify-and-store-mocha-results:
expectedResultCount: 10
expectedResultCount: 9

verify-release-readiness:
<<: *defaults
Expand Down
2 changes: 1 addition & 1 deletion guides/esm-migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ When migrating some of these projects away from the `ts-node` entry [see `@packa
- [x] packages/electron ✅ **COMPLETED**
- [ ] packages/https-proxy
- [ ] packages/icons
- [ ] packages/launcher
- [x] packages/launcher ✅ **COMPLETED**
- [ ] packages/net-stubbing
- [x] packages/network ✅ **COMPLETED**
- [ ] packages/packherd-require
Expand Down
3 changes: 2 additions & 1 deletion packages/launcher/.eslintignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
**/dist
**/cjs
**/esm
**/*.d.ts
**/package-lock.json
**/tsconfig.json
Expand Down
2 changes: 2 additions & 0 deletions packages/launcher/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
cjs/
esm/
123 changes: 0 additions & 123 deletions packages/launcher/__snapshots__/browsers_spec.ts.js

This file was deleted.

219 changes: 0 additions & 219 deletions packages/launcher/__snapshots__/darwin_spec.ts.js

This file was deleted.

Loading